Fix createStoryline gas limit + indexer 502 delay#254
Conversation
500-step bonding curve creation requires ~14.4M gas. The 5M limit from PR #245 caused OutOfGas reverts. 16M provides safe headroom. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Base Sepolia load-balanced RPCs need propagation time after heavy txs. Restores the 5s client-side delay removed in commit 71c66b8. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
APPROVE
Two surgical one-line fixes, both correct:
-
Gas limit 5M → 16M: 500-step bonding curve at ~14.4M needs headroom. 16M gives ~10% margin without hitting the block gas limit (~30M on Base). Good.
-
5s delay before indexer call: Fixed-delay workaround for RPC propagation lag is appropriate for a testnet. The
await new Promise(r => setTimeout(r, 5000))is placed correctly — afterwaitForTransactionReceiptreturns but before the indexer POST.
No issues found.
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR matches both issues and keeps the changes tightly scoped. createStoryline gets the required 16M gas headroom, and usePublish restores the 5s post-confirmation delay before the indexer call.
Findings
- [info] No blocking issues found.
Decision
Approve. The patch implements the requested fixes without changing unrelated publish behavior. CI was still pending when reviewed.
2 participants
Summary
createStorylinegas limit from 5M to 16M — the 500-step bonding curve requires ~14.4M gas, causing OutOfGas reverts at 5MusePublish— Base Sepolia load-balanced RPCs need propagation time, especially after heavy txs likecreateStorylineFixes #251
Fixes #252
Test plan
createStorylinetx succeeds without OutOfGas revertnpm run typecheckpasses🤖 Generated with Claude Code